Incremental programming

Tangent5280, 11 months ago

How do I view this image in full resolution on Jerboa? Currently only able to see the low res version

aktenkundig, 11 months ago

There’s a download button in the top right. Not really convenient though, as you then need to go find the downloaded picture yourself.

Tangent5280, 11 months ago

Thank you, this helps, although jerboa really should have a button for full res right next to the download button.

beardedrhino, 11 months ago

What am I looking at here? It just always goes to the first case right? 🤔

fsniper, 11 months ago

It's not the real issue. I introduced that while anonymizing the data. It's that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)

Something like below would be huge improvement:

subs1 = ["cluster1", "cluster2"]
if subs1.contains(clusterName) return subs1

Crackhappy, 11 months ago

Lol. Dude, you can’t do that to a bunch of coders and not expect them to read it literally.

fsniper, 11 months ago

Yep that's on me:) let's call this second breakfast!

Crackhappy, 11 months ago

Love you fam. :)

n3cr0, 11 months ago

Lecturer: “Always comment your code.”

Student: “The code documents itself!”

Also student: [see screenshot]

nuez_jr, 11 months ago

If any post was ever deserving of a +1 this is it right here.

fsniper, 11 months ago

And no reason to state this is from production.

fsniper, 11 months ago

no one looks behind and questions how and why.

Tangent5280, 11 months ago

No time in the development cycle for code review/refactors?

fsniper, 11 months ago

It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too..