Yeah and it’s noticeable that in movies that take place in modern times have less and less smoking all the time, which accurately reflects the real world drop in smoking.
Most smoking in movies you see today are either
A) Historical, when smoking was practically ubiquitous
B) Part of the character they’re playing. If you’re playing someone who is generally super unhealthy, or makes bad decisions, or is otherwise in a bad mental place, smoking can help present those negative characteristics to the viewer