[SOLVED] Help requested: Screenshot taken but disabled buttons still visible

Hi everyone, I was hoping someone could help me with the following. I have a button that saves a screenshot PNG to the Downloads folder when you press it.

What I want is for the button to disappear after it is pressed, so the screenshot does not include the two menu buttons called “%SaveReport” and “%BackMainMenu”.

The code for the save button is listed below:

`

func _on_SaveReport_pressed():


<span style="color:#323232;">$"%SaveReport".visible = false
</span><span style="color:#323232;">
</span><span style="color:#323232;">$"%BackMainMenu".visible = false
</span><span style="color:#323232;">
</span><span style="color:#323232;">print("I've disabled the buttons")
</span><span style="color:#323232;">print("That means the screenshot SHOULD be button free")
</span><span style="color:#323232;">
</span><span style="color:#323232;">take_screenshot()
</span><span style="color:#323232;">
</span><span style="color:#323232;">$"%SaveReport".visible = true
</span><span style="color:#323232;">$"%BackMainMenu".visible = true
</span>

`

As you can see, it calls the take_screenshot() function which is listed above:

`

func take_screenshot(): image = get_viewport().get_texture().get_image()


<span style="color:#323232;">if OS.get_name() == "Web" or OS.has_feature('JavaScript'):
</span><span style="color:#323232;">	print("We're on the web")
</span><span style="color:#323232;">	# We're on the web		
</span><span style="color:#323232;">
</span><span style="color:#323232;">	image.clear_mipmaps()
</span><span style="color:#323232;">
</span><span style="color:#323232;">	var buffer = image.save_png_to_buffer()
</span><span style="color:#323232;">	JavaScriptBridge.download_buffer(buffer, fileName)
</span><span style="color:#323232;">
</span><span style="color:#323232;">if OS.get_name() != "Web" or !OS.has_feature('JavaScript'):
</span><span style="color:#323232;">	# We're not on the web
</span><span style="color:#323232;">	print("We're not on the web")
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	var docs = OS.get_environment("HOME") + "/Documents"
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	var title = str(docs + "/results",global_ints.observed_person_name, global_ints.observation_minutes,".png")
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	print(title)
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	var _saveimage = image.save_png(title)
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	if OS.get_name() != "OSX":
</span><span style="color:#323232;">		print("We're not on MacOS")
</span><span style="color:#323232;">		var _openfolder = OS.shell_open(docs)
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	if OS.get_name() == "OSX":
</span><span style="color:#323232;">		print("We're on MacOS")
</span><span style="color:#323232;">		
</span><span style="color:#323232;">		var _openfolder = OS.shell_open("file://" + docs)
</span>

`

The code works. The screenshot is taken and it’s saved to the Downloads folder and MacOS/Windows/Linux open up the Downloads folder straight after.

For the life of me, I can’t figure out why the Back & Screenshot buttons ( “%SaveReport” and “%BackMainMenu”) that I turn invisible BEFORE I call take_screenshot() end up being in the screenshot. Every single time.

Anyone have any ideas?

Thank you!

bruce965,
@bruce965@lemmy.ml avatar

You will have to “await” the next frame after disabling the buttons, then take the screenshot and re-enable the buttons.

Otherwise you might be able to get the same effect by putting the buttons on a separate layer and excluding it from the screenshot (not sure if it’s actually possible this way, but I strongly suppose so).

HobbesHK,

I took away the 2 .visible = true commands at the end, just to see if they were the culprit. They are not. It appears that the get_viewport().get_texture().get_image() command gets called before the interface elements are turned off, even though the order of code would make me think otherwise.

PoolloverNathan,

You did turn off the interface elements, but too late for the viewport image to reflect that (as it was taken at the end of last frame). Like @bruce965 said, you should use await get_tree().idle_frame to wait until the image up to date, then get and save it.

HobbesHK,

await get_tree().idle_frame

Thank you for this! I just tried it out but unfortunately Godot throws an error on await get_tree().idle_frame : Invalid get index ‘idle_frame’ (on base: ‘SceneTree’).

Could it be because I’m running in application mode, which only refreshes the screen if there’s an update?

As an alternative, I’ve put the code to turn things off into its own function:


<span style="color:#323232;">func turn_off():
</span><span style="color:#323232;">	$"%SaveReport".visible = false
</span><span style="color:#323232;">	$"%BackMainMenu".visible = false
</span>

I’ve then tried an await turn_off()

The code runs, but doesn’t do anything and the screenshot still gets saved with the buttons visible.

I’m trying both await functions just before the take_screenshot() function like so:


<span style="color:#323232;">	await turn_off()
</span><span style="color:#323232;">	await get_tree().idle_frame
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	take_screenshot()
</span>

Am I missing something very obvious here? Any help would be much appreciated!

HobbesHK,

Managed to fix it by using await get_tree().process_frame instead. It seems that idle_frame appears to no longer exist in Godot 4.1?

So my full code for triggering the screenshot function is:


<span style="color:#323232;">func _on_SaveReport_pressed():
</span><span style="color:#323232;">	await get_tree().process_frame
</span><span style="color:#323232;">	$"%SaveReport".visible = false
</span><span style="color:#323232;">	$"%BackMainMenu".visible = false
</span><span style="color:#323232;">	await get_tree().process_frame
</span><span style="color:#323232;">	
</span><span style="color:#323232;">	take_screenshot()
</span><span style="color:#323232;">
</span><span style="color:#323232;">	$"%SaveReport".visible = true
</span><span style="color:#323232;">	$"%BackMainMenu".visible = true
</span>

For some reason, I have to await before I turn the interface elements off, and after I’ve turned them off. It now works a treat for my app. Thank you for your assistance!

PoolloverNathan,

Oh nice, Godot changed something again. TIL about process_frame, thanks!

  • All
  • Subscribed
  • Moderated
  • Favorites
  • •
  • random
  • uselessserver093
  • Food
  • aaaaaaacccccccce
  • test
  • CafeMeta
  • [email protected]
  • testmag
  • MUD
  • RhythmGameZone
  • RSS
  • dabs
  • TheResearchGuardian
  • Ask_kbincafe
  • KbinCafe
  • feritale
  • Socialism
  • oklahoma
  • SuperSentai
  • KamenRider
  • All magazines
    •