Reading the Apple Human Interface Guideline, it states the following:
If you use a button that behaves like a toggle, you generally use an interface icon that communicates its purpose, and you update its appearance — typically by changing the background — based on the current state.
So Design 1 lays closest to best practice. Regarding the ellipsis menu, I’m not sure what to do there. I’d really like a consistent approach, but a stroke-and-filled state might lead to more confusion than what’s there currently. I’m all in on your Design 1 right now.