I used to upgrade every generation, and yeah, it was stupidly expensive. But it was my only hobby, and you could actually seen performance increases each time.
But for the last 10 years or so, there’s much less point. Sometimes there are major advances (Cuda, RTX) that make it worthwhile for a single generation upgrade, but mostly it’s just a few FPS at highest settings. So now I just upgrade every few years.